WIP: Highlight history modifiers (#485) #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

danielshahaf wants to merge 2 commits into zsh-users:master from danielshahaf:i485-history-modifiers-v2

Member

danielshahaf commented Mar 15, 2020

This is #485 (comment), rebased and with the tests written (for reasons explained there).

Concerns:

Highlight parameter expansion history modifiers #485 (comment) "Modifiers require braces when KSH_ARRAYS is set."
Highlight parameter expansion history modifiers #485 (comment) Modifiers with arguments
The :t2/:h2 modifier (new since Highlight parameter expansion history modifiers #485) - https://github.com/zsh-users/zsh/blob/e5765bfdc89f131d03051ba4963819fdfe252503/README#L49-L63
Highlight parameter expansion history modifiers #485 (comment) @phy1729 requested that "[some unknown referent] and the parameter handling in _highlight_arguments should be pulled out into a new function" — @phy1729, do you by chance recall what the words "that bit" referred to?

danielshahaf added 2 commits

March 15, 2020 19:27


          'main': Break out a common pattern. No functional change.

e038a59


          'main': Highlight parameter expansion history modifiers.

fccfc69

Fixes zsh-users#485.

danielshahaf added this to the 0.8.0 milestone

Member Author

danielshahaf commented May 22, 2020

Triage: incomplete, new feature (as opposed to bugfix), 0.8.0 has plenty of content already merged, redrawhook is the next priority: demilestone.

danielshahaf removed this from the 0.8.0 milestone

danielshahaf mentioned this pull request

Highlight parameter expansion history modifiers #485

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet